[google_maps_flutter] Take snapshot of map #2607

miyakeryo · 2020-03-14T08:45:06Z

Description

Added function for taking a snapshot of the map

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

googlebot · 2020-03-14T08:45:14Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

miyakeryo · 2020-03-14T08:52:19Z

@googlebot I signed it! and we'll verify it.

googlebot · 2020-03-14T08:52:27Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cyanglaz

LGTM! I left some comments!

...le_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java

cyanglaz · 2020-03-18T17:40:59Z

packages/google_maps_flutter/google_maps_flutter/example/test_driver/google_maps_e2e.dart

+
+    final GoogleMapInspector inspector = await inspectorCompleter.future;
+    final Uint8List bytes = await inspector.takeSnapshot();
+    expect(bytes, isNotNull);


we can probably remove this as if bytes is null, the below test would fail as well.

packages/google_maps_flutter/google_maps_flutter/ios/Classes/GoogleMapController.m

…f_map

cyanglaz

LGTM modulo nits. Thanks!

cyanglaz · 2020-03-23T16:26:37Z

AUTHORS

+Giancarlo Rocha <giancarloiff@gmail.com>
+Ryo Miyake <ryo@miyake.id>


could you add new line EOF here?

cyanglaz · 2020-03-23T16:27:37Z

packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.5.25+1
+
+* Added function for taking a snapshot of the map.


nits: Add takeSnapshot that takes a snapshot of the map.

cyanglaz · 2020-03-23T16:28:52Z

packages/google_maps_flutter/google_maps_flutter/example/test_driver/google_map_inspector.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.

+import 'dart:typed_data';
+


nits: remove extra line here.

It's required to use Uint8List.

oh! extra line. ok

…f_map

cyanglaz

LGTM!

miyakeryo · 2020-03-24T23:35:16Z

thanks!

fvisticot · 2020-04-16T20:38:43Z

I need to take the snapshot once the map widget has been renderer:

using WidgetsBinding.instance.addPostFrameCallback

_onAfterBuild(BuildContext context) async {
    if (_image == null) {
      final GoogleMapController controller = await _completer.future;
      final bytes = await controller?.takeSnapshot();
      _image = Image.memory(bytes);
    }
  }

I get a crash on iOS (stable version)


Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Data cannot be nil'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff23c7127e __exceptionPreprocess + 350
	1   libobjc.A.dylib                     0x00007fff513fbb20 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff23c70ff8 +[NSException raise:format:arguments:] + 88
	3   Foundation                          0x00007fff256e9b51 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 191
	4   Flutter                             0x000000010381ae08 -[FlutterStandardTypedData initWithData:type:] + 335
	5   Flutter                             0x000000010381aca0 +[FlutterStandardTypedData typedDataWithData:type:] + 59
	6   Runner                              0x0000000102bdfd28 -[FLTGoogleMapController onMethodCall:result:] + 4584
	7   Runner                              0x0000000102bdeae1 __75-[FLTGoogleMapController initWithFrame:viewIdentifier:arguments:registrar:]_block_invoke + 161
	8   Flutter                             0x0000000103818b35 __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 104
	9   Flutter                             0x00000001037ac920 _ZNK7flutter21PlatformMessageRouter21HandlePlatformMessageEN3fml6RefPtrINS_15PlatformMessageEEE + 166
	10  Flutter                             0x00000001037b03ce _ZN7flutter15PlatformViewIOS21HandlePlatformMessageEN3fml6RefPtrINS_15PlatformMessageEEE + 38
	11  Flutter                             0x00000001038126e9 _ZNSt3__110__function6__funcIZN7flutter5Shell29OnEngineHandlePlatformMessageEN3fml6RefPtrINS2_15PlatformMessageEEEE4$_32NS_9allocatorIS8_EEFvvEEclEv + 57
	12  Flutter                             0x00000001037bf8f3 _ZN3fml15MessageLoopImpl10FlushTasksENS_9FlushTypeE + 117
	13  Flutter                             0x00000001037c4638 _ZN3fml17MessageLoopDarwin11OnTimerFireEP16__CFRunLoopTimerPS0_ + 26
	14  CoreFoundation                      0x00007fff23bd4b94 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
	15  CoreFoundation                      0x00007fff23bd4882 __CFRunLoopDoTimer + 1026
	16  CoreFoundation                      0x00007fff23bd3eda __CFRunLoopDoTimers + 266
	17  CoreFoundation                      0x00007fff23bcec4e __CFRunLoopRun + 2238
	18  CoreFoundation                      0x00007fff23bce066 CFRunLoopRunSpecific + 438
	19  GraphicsServices                    0x00007fff384c0bb0 GSEventRunModal + 65
	20  UIKitCore                           0x00007fff48092d4d UIApplicationMain + 1621
	21  Runner                              0x00000001026cbc2b main + 75
	22  libdyld.dylib                       0x00007fff5227ec25 start + 1
	23  ???                                 0x0000000000000001 0x0 + 1

cyanglaz · 2020-04-16T21:38:25Z

@fvisticot Thanks for finding this out. Do you mind open an issue with details about this crash and tag me there?
In your issue, it would be super helpful if you can provide a reduced test case. It will help us to reproduce the issue quickly and get resolved quickly.

greensopinion · 2021-05-03T15:02:55Z

I get a crash on iOS (stable version)

I've filed an issue with reproduction steps: flutter/flutter#81690

miyakeryo added 4 commits March 14, 2020 16:24

[google_maps_flutter] Add takeScreenshot

266ee88

[google_maps_flutter] Add example for takeScreenshot

95ed568

[google_maps_flutter] Modify takeScreenshot

274fae3

[google_maps_flutter] Add test for takeScreenshot

7e87384

googlebot added the cla: no label Mar 14, 2020

[google_maps_flutter] update version

f1737ad

googlebot added cla: yes and removed cla: no labels Mar 14, 2020

miyakeryo added 4 commits March 14, 2020 17:55

[google_maps_flutter] Fix format

f53538a

[google_maps_flutter] Fix format

a011122

[google_maps_flutter] Rename to takeSnapshot

c12c4b1

[google_maps_flutter] Fix format

1b29a3c

miyakeryo changed the title ~~[google_maps_flutter] Take screenshot of map~~ [google_maps_flutter] Take snapshot of map Mar 14, 2020

cyanglaz reviewed Mar 18, 2020

View reviewed changes

cyanglaz added the submit queue The Flutter team is in the process of landing this PR. label Mar 18, 2020

cyanglaz self-assigned this Mar 18, 2020

miyakeryo added 3 commits March 21, 2020 16:19

Merge remote-tracking branch 'upstream/master' into take_screenshot_o…

82990eb

…f_map

[google_maps_flutter] Madify takeSnapshot

4ee0fc5

Update AUTHORS

0217242

otopba approved these changes Mar 22, 2020

View reviewed changes

cyanglaz reviewed Mar 23, 2020

View reviewed changes

miyakeryo added 3 commits March 24, 2020 09:00

Merge remote-tracking branch 'upstream/master' into take_screenshot_o…

4d68aac

…f_map

[google_maps_flutter] Update CHANGELOG and AUTHORS

5b83189

[google_maps_flutter] Remove extra line

bf96404

cyanglaz reviewed Mar 24, 2020

View reviewed changes

cyanglaz approved these changes Mar 24, 2020

View reviewed changes

cyanglaz merged commit 03182d2 into flutter:master Mar 24, 2020

This was referenced Mar 26, 2020

[google_maps_flutter] Maps snapshot #1719

Closed

How to take screenshot of Google Map in flutter flutter/flutter#33557

Closed

This was referenced Apr 21, 2020

[google_maps_flutter] 'UIGraphicsImageRendererFormat' and 'defaultFormat is only available on iOS 10.0 or newer flutter/flutter#55258

Closed

[google_maps_flutter] Fix UIKit availability and pod lint warnings #2681

Merged

EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020

[google_maps_flutter] Take snapshot of map (flutter#2607)

5b02f85

tek08 mentioned this pull request Jun 18, 2020

iOS: Google Maps views are not captured mmcc007/screenshots#93

Closed

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[google_maps_flutter] Take snapshot of map (flutter#2607)

a4bf402

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[google_maps_flutter] Take snapshot of map (flutter#2607)

d3a3dc6

greensopinion mentioned this pull request May 3, 2021

[google_maps_flutter] iOS native crash when map is offscreen flutter/flutter#81690

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_maps_flutter] Take snapshot of map #2607

[google_maps_flutter] Take snapshot of map #2607

miyakeryo commented Mar 14, 2020 •

edited

Loading

googlebot commented Mar 14, 2020

miyakeryo commented Mar 14, 2020

googlebot commented Mar 14, 2020

cyanglaz left a comment

cyanglaz Mar 18, 2020

cyanglaz left a comment

cyanglaz Mar 23, 2020

cyanglaz Mar 23, 2020

cyanglaz Mar 23, 2020

miyakeryo Mar 24, 2020

miyakeryo Mar 24, 2020

cyanglaz left a comment

miyakeryo commented Mar 24, 2020

fvisticot commented Apr 16, 2020

cyanglaz commented Apr 16, 2020

greensopinion commented May 3, 2021

		Giancarlo Rocha <giancarloiff@gmail.com>
		Ryo Miyake <ryo@miyake.id>

		@@ -1,3 +1,7 @@
		## 0.5.25+1

		* Added function for taking a snapshot of the map.

[google_maps_flutter] Take snapshot of map #2607

[google_maps_flutter] Take snapshot of map #2607

Conversation

miyakeryo commented Mar 14, 2020 • edited Loading

Description

Related Issues

Checklist

Breaking Change

googlebot commented Mar 14, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

miyakeryo commented Mar 14, 2020

googlebot commented Mar 14, 2020

cyanglaz left a comment

Choose a reason for hiding this comment

cyanglaz Mar 18, 2020

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

cyanglaz Mar 23, 2020

Choose a reason for hiding this comment

cyanglaz Mar 23, 2020

Choose a reason for hiding this comment

cyanglaz Mar 23, 2020

Choose a reason for hiding this comment

miyakeryo Mar 24, 2020

Choose a reason for hiding this comment

miyakeryo Mar 24, 2020

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

miyakeryo commented Mar 24, 2020

fvisticot commented Apr 16, 2020

cyanglaz commented Apr 16, 2020

greensopinion commented May 3, 2021

miyakeryo commented Mar 14, 2020 •

edited

Loading